Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex Rule CRUD through CLI #952

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Cortex Rule CRUD through CLI #952

merged 2 commits into from
Jan 6, 2023

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Jan 6, 2023

Decided to limit LoadRules & DeleteRule api to a single cluster to limit unintended side effects from the caller

joshmeranda
joshmeranda previously approved these changes Jan 6, 2023
Copy link
Contributor

@joshmeranda joshmeranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandreLamarre alexandreLamarre merged commit 52dcacf into main Jan 6, 2023
@alexandreLamarre alexandreLamarre deleted the cortex-rule-cli branch February 15, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants