Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opni enhancement proposal template and vale style guide #961

Merged
merged 6 commits into from
Jan 20, 2023
Merged

opni enhancement proposal template and vale style guide #961

merged 6 commits into from
Jan 20, 2023

Conversation

sanjay920
Copy link
Contributor

No description provided.

dbason
dbason previously approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@dbason dbason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to update the /gitignore file so people don't accidentally commit files from a vale sync

dbason
dbason previously approved these changes Jan 20, 2023
View reviewed changes
@tybalex
Copy link
Contributor

tybalex commented Jan 20, 2023

can you also add example commends to run to apply vale so everyone can just follow that

@sanjay920
Copy link
Contributor Author

can you also add example commends to run to apply vale so everyone can just follow that

added https://github.com/rancher/opni/blob/processes/vale.md

tybalex
tybalex approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@tybalex tybalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sanjay920 sanjay920 merged commit b6b9883 into main Jan 20, 2023
@sanjay920 sanjay920 deleted the processes branch January 20, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tybalex tybalex tybalex approved these changes

@dbason dbason dbason left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanjay920 @tybalex @dbason