This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Refactor a little so 'ros os list' also uses the configured proxy info #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
|
mmm, looks to me like we're not passing the proxy env to the consoles and not setting the global env vars based on the |
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
SvenDowideit
force-pushed
the
http-proxy-fix
branch
from
d8ee8bd
to
4769f14
Compare
SvenDowideit
added a commit
to SvenDowideit/os
that referenced
this pull request
Sep 18, 2017
Refactor a little so 'ros os list' also uses the configured proxy info (cherry picked from commit f7327d7)
|
backported to 1.0.5_ #2110 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1914
also set http_proxy env vars for consoles.
I'm having issues with
wgetin thedefaultconsole still, but it works with the proxy in the debian console - I might leave that for the future tho.Important note if you need to
sudo, usesudo -iso you get the/etc/profile.d/*env, in which the proxy env is set.