Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Airlock Microgateway and Airlock Microgateway CNI #1035

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

tyxeron
Copy link
Contributor

@tyxeron tyxeron commented Jun 21, 2024

Hi 👋

These two commits add the Airlock Microgatway and Airlock Microgateway CNI Helm charts.

Thanks for reviewing

GitHub Repo: https://github.com/airlock/microgateway

@tyxeron tyxeron requested a review from a team as a code owner June 21, 2024 08:24
@recena
Copy link
Collaborator

recena commented Jul 3, 2024

📔 This contribution will be reviewed soon.

@troytop
Copy link
Contributor

troytop commented Jul 3, 2024

@tyxeron please see the email I sent regarding the SUSE Ready partner application. We'll review and merge the PR after that process is complete (and I'll update the README so this is clearer for others).

@tyxeron
Copy link
Contributor Author

tyxeron commented Jul 5, 2024

Thanks for your help :)
I have a question regarding the overlay files. For our CNI plugin one needs to set three values that depend on your distribution and CNI setup (e.g. if you use multus). Is there a way with the overlay files to provide kubernetes distribution specific Helm values?

@adamkpickering
Copy link
Collaborator

The partner charts build tool (partner-charts-ci) does not provide a way to set kubernetes distribution specific Helm values. At the time that an upstream chart is processed for inclusion into the partner charts repo, partner-charts-ci does not have any info about what environment the chart will be installed into. To the best of my knowledge, your options are:

  • Provide different charts for different environments. I don't recommend this, since this is not the typical way of doing things and it could confuse users.
  • Have the users configure your application for the environment they are installing it into. questions.yml may come in handy for this - you would add it as an overlay file. Alternatively the user can configure the application via Values as is usually done when installing a chart via helm install. The Rancher UI provides a way to do this without having to use the helm CLI tool.

I hope that helps 😄

@tyxeron
Copy link
Contributor Author

tyxeron commented Jul 8, 2024

@adamkpickering Thanks for your reply :) I already have a questions.yml file so I hope that should be sufficient for the user to install it.

Copy link
Collaborator

@adamkpickering adamkpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However we are in the middle of a migration, so I am going to hold off on approval. We should have the migration completed in the next day or two.

@adamkpickering adamkpickering merged commit aa4cbe5 into rancher:main-source Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants