Fix icon URL for some (not all) charts #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkpickering
force-pushed
the
fix-some-icons
branch
from
0ed1af4
to
a660c67
Compare
|
What about the new ones like this? |
|
After PRs that add new packages are merged, running |
diogoasouza
previously approved these changes
Jul 12, 2024
|
|
adamkpickering
force-pushed
the
fix-some-icons
branch
from
a660c67
to
5752a5c
Compare
|
Good catch @recena. It should be fixed now. |
recena
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rancher/partner-charts-ci#22 I modified the
download-iconssubcommand ofpartner-charts-ci(and also renamed it toensure-icons). It now does more. This PR is the result of runningpartner-charts-ci ensure-iconson this repo - it downloads icons for more charts than we could get before.If you're curious as to why we couldn't get these icons before, the answer is technical debt. There was a function called
populatePackages()that was the only way to list packages. But this function did more than that: it also checked whether there were any new upstream versions for a package. For some packages (i.e. the ones for which icons are added in this PR), there were errors when runningpopulatePackages(), so they were skipped.The reason I am able to add icons for them here is because I have split
populatePackages()by function:listPackageWrappers()now lists packages, andPackageWrapper.Populate()checks upstream for new versions.partner-charts-ci ensure-iconsonly needs to calllistPackageWrappers(), so we can avoid the errors onPackageWrapper.Populate()for these packages.