-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1281 docker machine link redirects to docker desktop documentation #1286
Merged
martyav
merged 5 commits into
rancher:main
from
martyav:1281-docker-machine-link-redirects-to-docker-desktop-documentation
May 15, 2024
Merged
#1281 docker machine link redirects to docker desktop documentation #1286
martyav
merged 5 commits into
rancher:main
from
martyav:1281-docker-machine-link-redirects-to-docker-desktop-documentation
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyav
requested review from
btat,
LucasSaintarbor and
sunilarjun
as code owners
May 14, 2024 14:37
jiaqiluo
approved these changes
May 14, 2024
sunilarjun
approved these changes
May 14, 2024
btat
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed URL looks like a fork of the repo hosted on a personal (someone outside of SUSE?) GitHub pages site.
We should point to the GitHub source instead https://github.com/docker/docs/blob/vnext-engine/machine/overview.md.
...ation-permissions-and-global-configuration/about-provisioning-drivers/manage-node-drivers.md
Outdated
Show resolved
Hide resolved
...ation-permissions-and-global-configuration/about-provisioning-drivers/manage-node-drivers.md
Outdated
Show resolved
Hide resolved
...ation-permissions-and-global-configuration/about-provisioning-drivers/manage-node-drivers.md
Outdated
Show resolved
Hide resolved
...ation-permissions-and-global-configuration/about-provisioning-drivers/manage-node-drivers.md
Outdated
Show resolved
Hide resolved
...ation-permissions-and-global-configuration/about-provisioning-drivers/manage-node-drivers.md
Outdated
Show resolved
Hide resolved
...ation-permissions-and-global-configuration/about-provisioning-drivers/manage-node-drivers.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Billy Tat <btat@suse.com>
btat
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1281
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, make sure to target the release branch instead of
main
.Description
Upon investigating the original problem, learned that:
Comments
Original comment from #1281: