Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM64 integration testing in backup-restore-operator #45420

Closed
MKlimuszka opened this issue May 8, 2024 · 6 comments
Closed

ARM64 integration testing in backup-restore-operator #45420

MKlimuszka opened this issue May 8, 2024 · 6 comments
Assignees
@mallardduck
Labels
area/backup-recover kind/tech-debt Formerly issues labeled as ci-improvements, tasks, flaky tests, and post-release. priority/4 team/observability&backup the team that is responsible for monitoring/logging and BRO

Comments

@MKlimuszka
Copy link
Collaborator

MKlimuszka commented May 8, 2024 •
edited
Loading

Most of backup-restore was migrated to GHA with integration testing in this PR
rancher/backup-restore-operator#455

But testing for ARM64 support was not included. This ticket will fix that.
@MKlimuszka MKlimuszka added area/backup-recover kind/enhancement Issues that improve or augment existing functionality labels May 8, 2024
@MKlimuszka MKlimuszka added the team/observability&backup the team that is responsible for monitoring/logging and BRO label May 8, 2024
@MKlimuszka MKlimuszka changed the title ARM64 support for Github Actions in backup-restore-operator ARM64 integration testing in backup-restore-operator May 14, 2024
@MKlimuszka MKlimuszka added priority/4 kind/tech-debt Formerly issues labeled as ci-improvements, tasks, flaky tests, and post-release. and removed kind/enhancement Issues that improve or augment existing functionality labels May 14, 2024
@mallardduck
Copy link
Member

We had a quick call on this and I want to summarize some things we found for future reference. Long story short, GHA added arm runners but only to orgs (so unlikely we can test on our forks).

The arm based runners are accessible via Rancher repos via their runs-on names, and examples listing the names can be found here: https://github.com/rancher/eio-test/actions/runs/8795155580/workflow

@mallardduck
Copy link
Member

WIP PR here: rancher/backup-restore-operator#555

@dharmit
Copy link
Contributor

dharmit commented Aug 28, 2024

@mallardduck @MKlimuszka should we keep this open or close it since rancher/backup-restore-operator#555 is merged? Maybe we want to keep it around for backport purpose?

@mallardduck
Copy link
Member

My vote would be keep it open until backports are sorted out. Once we merge in rancher/backup-restore-operator#566 manual backport PRs can be created for our other active branches (Rancher 2.8+ / BRO 4/5).

@mallardduck
Copy link
Member

Backport PRs are in review now:
rancher/backup-restore-operator#569
rancher/backup-restore-operator#570
rancher/backup-restore-operator#571

@mallardduck
Copy link
Member

All merged up! Setting this solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mallardduck mallardduck

Labels
area/backup-recover kind/tech-debt Formerly issues labeled as ci-improvements, tasks, flaky tests, and post-release. priority/4 team/observability&backup the team that is responsible for monitoring/logging and BRO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mallardduck @dharmit @MKlimuszka @alexandreLamarre