Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to GHA #455

Merged
merged 12 commits into from
Apr 30, 2024
Merged

Migration to GHA #455

merged 12 commits into from
Apr 30, 2024

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Apr 11, 2024

  • Adds goreleaser for binary release CI, a standard release tool for go binaries. Preserves the same static link flags as our package script
  • Migrates main CI (build & test) to gha dynamic matrices (linuxamd, linuxarm) x (min_supported_k8s-version, max_supported_k8s_version)
  • Migrates image building CI to using docker-build-and-push action using buildx and docker manifests.

⚠️ Does not include arm64 support, will follow up in a separate PR on this

image
image

@alexandreLamarre alexandreLamarre force-pushed the gha branch 9 times, most recently from 548066e to f2180d5 Compare April 17, 2024 19:15
@alexandreLamarre alexandreLamarre force-pushed the gha branch 4 times, most recently from dae50fc to 04b8afd Compare April 22, 2024 19:55
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
.goreleaser.yaml Outdated Show resolved Hide resolved
scripts/integration Outdated Show resolved Hide resolved
scripts/integration Outdated Show resolved Hide resolved
Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits. The CI files look good, and it's helpful that the github actions are passing.

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
@alexandreLamarre alexandreLamarre force-pushed the gha branch 2 times, most recently from e3c9223 to 5320343 Compare April 25, 2024 15:57
@alexandreLamarre alexandreLamarre marked this pull request as draft April 25, 2024 16:42
@alexandreLamarre alexandreLamarre force-pushed the gha branch 3 times, most recently from 177eb71 to 0dd9714 Compare April 25, 2024 16:57
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
@alexandreLamarre alexandreLamarre marked this pull request as ready for review April 29, 2024 16:26
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericpromislow - IIRC you said you would handle this round of release stuff for BRO. So if we merge this before that release then this will most directly affect you, so i'll mostly defer to your call - beyond this initial review.

Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@ericpromislow ericpromislow merged commit f83e024 into release/v5.0 Apr 30, 2024
3 checks passed
@alexandreLamarre alexandreLamarre deleted the gha branch May 1, 2024 17:50
This was referenced May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants