[Forwardport] [v2.9] Rancher k8s v1.28.6 update #45082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jiaqiluo
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
It looks like some changes in the original PR have been in the release/v2.9 branch, and this PR covers the part that are not. Also, the etcd version in the release/v2.9 branch is v3.5.12 which is higher than v3.5.9 that is used in the upstream v1.28.6+k3s2, which should be ok.
kinarashah
previously approved these changes
Apr 16, 2024
chiukapoor
force-pushed
the
1.28-in-2.9
branch
5 times, most recently
from
36c9d47
to
43429a4
Compare
|
Successfully tested k8s |
|
It seems like the CI is failing after the rancher/ui-plugin-examples#38 was merged. I tried to fix it in e398e5d but no success. EDIT: The issue is being tracked here #45159 |
jiaqiluo
previously approved these changes
Apr 18, 2024
jiaqiluo
previously approved these changes
Apr 19, 2024
…e and Jenkinsfile Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
bump machine to v0.15.0-rancher110 bump client-go to v1.28.6-rancher1 Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
…etes#118384] Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
…kUnstructured struct Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
* rke to 1.6.0-rc1 * kdm to dev-v2.9 * cli version to v2.9.0-rc1 * rancher-agent to v2.9 Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
jiaqiluo
approved these changes
Apr 23, 2024
snasovich
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Changes look sane to me and given previous approval by @kinarashah and now @jiaqiluo it's good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Updates
gnosticdependencies tognostic-modelsacross the code base. Update gnostic library to point to gnostic-models kubernetes/kubernetes#118384v0.1.23