-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] [v2.9] Rancher k8s v1.28.6 update #45082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like some changes in the original PR have been in the release/v2.9 branch, and this PR covers the part that are not. Also, the etcd version in the release/v2.9 branch is v3.5.12 which is higher than v3.5.9 that is used in the upstream v1.28.6+k3s2, which should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rebase and update kdm + rke, but rest LGTM. Will reapprove before merge.
36c9d47
to
43429a4
Compare
Successfully tested k8s |
It seems like the CI is failing after the rancher/ui-plugin-examples#38 was merged. I tried to fix it in e398e5d but no success. EDIT: The issue is being tracked here #45159 |
…e and Jenkinsfile Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
bump machine to v0.15.0-rancher110 bump client-go to v1.28.6-rancher1 Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
…etes#118384] Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
…kUnstructured struct Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
* rke to 1.6.0-rc1 * kdm to dev-v2.9 * cli version to v2.9.0-rc1 * rancher-agent to v2.9 Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sane to me and given previous approval by @kinarashah and now @jiaqiluo it's good to merge.
Issue
Updates
gnostic
dependencies tognostic-models
across the code base. Update gnostic library to point to gnostic-models kubernetes/kubernetes#118384v0.1.23