Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5] add timeout to etcd member add #3536

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

kinarashah
Copy link
Member

@kinarashah kinarashah commented Mar 20, 2024

Issue: rancher/rancher#45539

  • Etcd client v3 kept retrying on member add vs v2 client used to return errors so we didn't have timeout earlier
  • DialTimeout alone doesn't suffice, also need to specify client request timeout with context
  • Updated to close all etcd clients as v3 client uses grpc to connect to etcd, could leave us with leaks if not closed

@zmedico
Copy link

zmedico commented May 6, 2024

Hi, I've also experienced etcd scaling issues with rancher-2.8.x that I did not experience with rancher-2.7.x, and this timeout for the v3 etcd client looks very promising, thanks!

@kinarashah kinarashah marked this pull request as ready for review May 20, 2024 22:25
@kinarashah kinarashah requested review from a team as code owners May 20, 2024 22:25
@kinarashah kinarashah marked this pull request as draft May 20, 2024 22:26
@kinarashah kinarashah marked this pull request as ready for review June 27, 2024 20:10
@snasovich snasovich removed the request for review from a team June 27, 2024 20:11
@kinarashah kinarashah merged commit 901cb5a into rancher:release/v1.5 Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants