Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.5] Add ACI CNI 6042 variables #3625

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

jeffinkottaram
Copy link
Contributor

@jeffinkottaram jeffinkottaram commented Jul 1, 2024

@jeffinkottaram jeffinkottaram requested a review from a team as a code owner July 1, 2024 09:44
snasovich
snasovich previously approved these changes Jul 2, 2024
@snasovich snasovich requested a review from kinarashah July 2, 2024 00:14
@kinarashah
Copy link
Member

@jeffinkottaram Changes LGTM, will approve after we merge KDM PR and PR updates data.json.

@kinarashah
Copy link
Member

@jeffinkottaram merged KDM PR, you can now run go generate to update data.json, thank you!

@snasovich
Copy link
Collaborator

@jeffinkottaram , also, we've merged CI changes that migrate it from Drone to GH Actions - not sure if GHAs will kick off automatically on push/force-push to source repo. If they don't, you may need to rebase your PR.

@jeffinkottaram
Copy link
Contributor Author

@kinarashah, the data.json here: https://releases.rancher.com/kontainer-driver-metadata/dev-v2.8/data.json doesn't yet seem to have picked up the changes.

@snasovich
Copy link
Collaborator

@jeffinkottaram , thank you for letting us know. Seems to be related to Drone -> GHA migration that's going on right now. We will look into this.

@snasovich
Copy link
Collaborator

@jeffinkottaram , https://releases.rancher.com/kontainer-driver-metadata/dev-v2.8/data.json is now updated per https://github.com/rancher/kontainer-driver-metadata/actions/runs/9796074885/job/27049991334.
You should be unblocked updating this.

@kinarashah kinarashah merged commit fa04078 into rancher:release/v1.5 Jul 5, 2024
9 checks passed
@jeffinkottaram jeffinkottaram deleted the aci-6042-rke-1.5.11 branch July 8, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants