-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed API version for poddisturtionbudget #361
Conversation
packages/rke2-canal/package.yaml
Outdated
@@ -1,2 +1,2 @@ | |||
url: local | |||
packageVersion: 00 | |||
packageVersion: 01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check the file termination? Somehow there is this character that github doesn't recognize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check it now?
File displays that it's ASCII text, cat displays line ends as $
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it's ok
Could you do a local rebase of your branch? |
Not sure I did it correctly, could you check please? |
try this
There should be a conflict on
You should be aligned with the remote and you should have only one commit with your fix. |
done |
You need to rebase your branch on top of main-source, instead of pulling main-source into your branch. Once you've done that, please squash your commits and force push. The PR branch is not mergable in its current state. |
55378ee
to
d50827d
Compare
In kubernetes version 1.25 the API policy/v1beta1 for PDB was removed The helm chart still uses this old API and is making upgrading impossible
e33fba1
to
fa247a6
Compare
Didn't think I'd have so much trouble rebasing... Anyways, please check if this works |
In kubernetes version 1.25 the API policy/v1beta1 for PDB was removed
The helm chart still uses this old API and is making upgrading impossible
Steps to reproduce: