Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serializable health checks for etcd probes #3073

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

brandond
Copy link
Member

@brandond brandond commented Jun 16, 2022

Proposed Changes

Use serializable health checks for etcd probes

Refs:

Types of Changes

bugfix

Verification

Check etcd static pod manifest

Linked Issues

Further Comments

Refs:
* kubernetes/kubernetes#110072
* etcd-io/etcd#13399

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner June 16, 2022 20:32
@codecov-commenter
Copy link

Codecov Report

Merging #3073 (6390b75) into master (8aa5295) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #3073   +/-   ##
======================================
  Coverage    4.96%   4.96%           
======================================
  Files          25      25           
  Lines        2053    2053           
======================================
  Hits          102     102           
  Misses       1925    1925           
  Partials       26      26           
Flag Coverage Δ
unittests 4.96% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/podexecutor/staticpod.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa5295...6390b75. Read the comment docs.

@brandond brandond merged commit d2854f0 into rancher:master Jun 16, 2022
@brandond brandond deleted the etcd_healthcheck_serializable branch June 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants