Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg/rke2): psa custom path #3665

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

perriea
Copy link

@perriea perriea commented Dec 8, 2022

Proposed Changes

In fact, a pod-security-admission-config-file flag exists to define an arbitrary path for the PSA. But even if the flag is set, the file is still created at /etc/rancher/rke2/rke2-pss.yaml (defaultPSAConfigFile). This is incorrect behavior.

Types of Changes

Bugfix

Linked Issues

/!\ This flag isn't registered in the documentation #3440

@perriea perriea requested a review from a team as a code owner December 8, 2022 15:15
@perriea
Copy link
Author

perriea commented Dec 20, 2022

Anyone is available to review this ?

@brandond
Copy link
Contributor

I believe this was intended behavior - we only write the default config file. If you provide your own config file path, it will be used, but you are responsible for populating it with the correct content. I would defer to @galal-hussein on that though.

@brandond
Copy link
Contributor

brandond commented Jan 3, 2023

To be clear @perriea - you object to the fact that RKE2 is writing the default configuration file out to the fixed location, even if you've specified a custom path that already contains your desired configuration?

@perriea
Copy link
Author

perriea commented Jan 4, 2023

Yes, otherwise I don't understand the existence of this flag which at this moment is useless or no sense 😅

@erikfuego
Copy link

Correct me if i'm wrong @perriea, but I think the point of this flag is for us to provide our own version of the admission-control-config.yaml right? Which is why the path stays the same on the node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants