Handle restart attempts in static pod manifest checks #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereknola
approved these changes
Sep 25, 2023
brandond
force-pushed
the
fix-pod-restart-attempts
branch
from
442f939
to
f917686
Compare
|
Changed to using upstream Have requested re-review. |
briandowns
approved these changes
Sep 25, 2023
johnatasr
approved these changes
Sep 25, 2023
brandond
force-pushed
the
fix-pod-restart-attempts
branch
4 times, most recently
from
eb017bd
to
cac3d2b
Compare
Fixes issue where pod sandbox changes may prevent running pods from being found. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-pod-restart-attempts
branch
from
cac3d2b
to
481ccf7
Compare
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes issue where pod restart attempts may obscure currently running pods from being found.
This switches to using upstream functions to determine the current pod sandbox, to ensure that rke2 is in sync with the kubelet.
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues
User-Facing Change
Further Comments