Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump harvester-cloud-provider v0.2.4 #5980

Merged

Conversation

Vicente-Cheng
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng commented May 24, 2024

Proposed Changes

Update the Harvester cloud provider version

Types of Changes

bump newer version

Verification

Regular tests for harvester-cloud-provider

Testing

Linked Issues

User-Facing Change

Bump Harvester-cloud-provider v0.2.4

Further Comments

@brandond
Copy link
Contributor

Current CI failures are due to a recently merged PR, I'll fix that tomorrow and you can rebase.

@Vicente-Cheng
Copy link
Contributor Author

Current CI failures are due to a recently merged PR, I'll fix that tomorrow and you can rebase.

Sure, thanks @brandond

Copy link
Contributor

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
@Vicente-Cheng Vicente-Cheng force-pushed the bump-harvester-cloud-provider branch from fec0fbe to 9c7431e Compare May 27, 2024 09:05
@Vicente-Cheng
Copy link
Contributor Author

needs rebase

Thanks @brandond,
rebased this PR and all backport PRs

Please help to review!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.86%. Comparing base (1dcd76d) to head (9c7431e).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #5980   +/-   ##
======================================
  Coverage    9.86%   9.86%           
======================================
  Files          32      32           
  Lines        2686    2686           
======================================
  Hits          265     265           
  Misses       2399    2399           
  Partials       22      22           
Flag Coverage Δ
inttests 9.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 0b46719 into rancher:master May 31, 2024
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants