Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install.sh: Only use RPM installation method on AMD64 #6313

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomWis97
Copy link

Proposed Changes

As described in issue #5135, the install.sh script fails on a RPM-based distribution on aarch64 systems. As the RPM method only supports AMD64, I propose we check if the architecture is indeed AMD64 and continue with the tar installation method if that's not the case.

We should clarify in the documentation that the RPM installation is at the moment only supported on x86_64.

Types of Changes

This is a bugfix, or, more like a workaround until the RPM method further matures.

Verification

  1. Run the script on a x64_64 system with a RPM-based distro. Observe the RPM installation method is chosen.
  2. Run the script on a aarch64 system with a RPM-based distro. Observe the tar installation method is chosen.

Testing

I believe this is not required for such a small change.

Linked Issues

#6312 and #5135

User-Facing Change

Installation script only uses the RPM installation method on x86_64-based systems.

Further Comments

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant