Don't pull and save all the images every build

[brandond]

Proposed Changes

Don't pull and save all the images every build

We only need to pull and save images when building tags, if building an untagged dev release, just inspect to make sure the images all exist.

This should shorten PR builds, as well as reducing the amount of throttling on docker hub pulls.

Types of Changes

ci

Verification

See CI logs - note that the images are still checked, but no longer pulled and packaged, when not building a release.

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.23%. Comparing base (b704157) to head (385e784).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6345   +/-   ##
=======================================
  Coverage   25.23%   25.23%           
=======================================
  Files          33       33           
  Lines        2829     2829           
=======================================
  Hits          714      714           
  Misses       2068     2068           
  Partials       47       47           

Flag	Coverage Δ
inttests	9.65% <ø> (ø)
unittests	17.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brandond]

Ugh apparently we can get rate-limited just inspecting...

+ docker manifest inspect docker.io/rancher/mirrored-sig-storage-snapshot-controller:v6.2.1
+ echo docker.io/rancher/mirrored-sig-storage-snapshot-controller:v6.2.1
+ docker manifest inspect docker.io/rancher/mirrored-sig-storage-snapshot-validation-webhook:v6.2.2
toomanyrequests: Too Many Requests (HAP429).
make: *** [Makefile:24: build] Error 123
time="2024-07-16T09:27:57Z" level=fatal msg="exit status 2"
Error: Process completed with exit code 1.

[brandond]

Can't do this while we're still using Dapper, as Dapper "fakes" a multi-stage build by running multiple builds on top of a tag, and the buildx containerized runner doesn't have an image store - so it fails to pull the tag for the secondary build step.