Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.30] Fix windows airgap image packaging #6585

Merged

Conversation

brandond
Copy link
Contributor

Proposed Changes

Fix windows airgap image packaging

Change to image source for airgap was missed from #4829 - airgap no longer contained the same images as RKE2 actually uses on Windows.

Types of Changes

bugfix

Verification

Check windows airgap tarball
Install windows airgap cluster

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner August 19, 2024 19:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.18%. Comparing base (ba87c79) to head (bd916c5).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.30    #6585   +/-   ##
=============================================
  Coverage         25.18%   25.18%           
=============================================
  Files                33       33           
  Lines              2831     2831           
=============================================
  Hits                713      713           
  Misses             2071     2071           
  Partials             47       47           
Flag Coverage Δ
inttests 9.57% <ø> (ø)
unittests 17.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit cdad5d0 into rancher:release-1.30 Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants