updated incorrect CIS controls Ids and version mapping #174
Conversation
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| controls: | |||
| version: "cis-1.23" | |||
| version: 1.23 | |||
There was a problem hiding this comment.
@KiranBodipi regarding the version name, I agree we should stick to kube-bench's format which uses version: cis-1.X and not version: 1.x.
IMO the cis-benchmark chart (or any other components) use cfgs filenames, so setting back the naming convention to version: cis-1.X in the yamls should be fine.
@rayandas could you confirm this ?
If we all approve this, let's change all files to use version: cis-1.X.
There was a problem hiding this comment.
Yeah we normally follow version: 1.x only. But I saw for a few configs there are version: cis-1.x which we can change to version: 1.x
There was a problem hiding this comment.
Or we can keep all the configs as version: cis-1.x same as kube-bench. It shouldn’t impact anything.
There was a problem hiding this comment.
I modified my first comment ^, kube-bench actually uses version: cis-1.x and not version: 1.x. We will have another PR to adjust all yamls to have version: cis-1.x.
There was a problem hiding this comment.
Raised rancher/cis-operator#248 to track the changes. Someone from my team will take it up.
|
@rayandas we will make another PR to include @KiranBodipi's changes and adjust all yamls to have |
updated the scripts with correct CIS control Ids for controls Ids and version mapping