Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update module github.com/prometheus/client_golang to v1.20.0 #199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(deps): update module github.com/prometheus/client_golang to v1.20.0 #199

wants to merge 2 commits into from

Conversation

renovate-rancher[bot]
Copy link
Contributor

@renovate-rancher renovate-rancher bot commented Apr 20, 2024 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
github.com/prometheus/client_golang require minor v1.16.0 -> v1.20.0

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.20.0

Compare Source

Thanks everyone for contributions!

⚠️ In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default collectors.NewGoCollector() collector. Given its popular usage, expect your binary to expose two additional metric.

Changes

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #​1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #​1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #​1568 #​1578
  • [FEATURE] testutil: Add CollectAndFormat method. #​1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #​1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #​1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #​1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #​1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #​1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #​1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #​1455
  • [BUGFIX] promhttp: Make sure server
    instrumentation wrapping supports new and future extra responseWriter methods. #​1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #​1424
All commits

New Contributors

Full Changelog: prometheus/client_golang@v1.19.1...v1.20.0

v1.19.1

Compare Source

What's Changed

  • Security patches for golang.org/x/sys and google.golang.org/protobuf

New Contributors

Full Changelog: prometheus/client_golang@v1.19.0...v1.19.1

v1.19.0

Compare Source

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See https://github.com/prometheus/client_golang/pull/1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #​1445 #​1449
  • [FEATURE] collectors: Add version collector. #​1422 #​1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0

v1.18.0

Compare Source

What's Changed

  • [FEATURE] promlint: Allow creation of custom metric validations. #​1311
  • [FEATURE] Go programs using client_golang can be built in wasip1 OS. #​1350
  • [BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. #​1367
  • [BUGFIX] testutil: Fix comparison of metrics with empty Help strings. #​1378
  • [ENHANCEMENT] Improved performance of MetricVec.WithLabelValues(...). #​1360

New Contributors

Full Changelog: prometheus/client_golang@v1.17.0...v1.18.0

v1.17.0

Compare Source

What's Changed

  • [CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). #​1325
  • [FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. #​1313
  • [ENHANCEMENT] Enable detection of a native histogram without observations. #​1314
Commits

New Contributors

Full Changelog: prometheus/client_golang@v1.16.0...v1.17.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@renovate-rancher renovate-rancher bot requested a review from a team as a code owner April 20, 2024 04:39
@renovate-rancher renovate-rancher bot added the dependencies Pull requests that update a dependency file label Apr 20, 2024
@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch from 6197521 to e816ffe Compare May 10, 2024 04:39
@renovate-rancher renovate-rancher bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.19.0 chore(deps): update module github.com/prometheus/client_golang to v1.19.1 May 10, 2024
@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch from e816ffe to fe0ac40 Compare May 11, 2024 04:39
@renovate-rancher renovate-rancher
Copy link
Contributor Author

renovate-rancher bot commented Jun 8, 2024 •
edited
Loading

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 11 additional dependencies were updated

Details:

Package Change
github.com/cespare/xxhash/v2 v2.2.0 -> v2.3.0
github.com/prometheus/client_model v0.4.0 -> v0.6.1
github.com/prometheus/common v0.44.0 -> v0.55.0
github.com/prometheus/procfs v0.10.1 -> v0.15.1
golang.org/x/crypto v0.22.0 -> v0.24.0
golang.org/x/net v0.24.0 -> v0.26.0
golang.org/x/oauth2 v0.16.0 -> v0.21.0
golang.org/x/sys v0.19.0 -> v0.22.0
golang.org/x/term v0.19.0 -> v0.21.0
golang.org/x/text v0.14.0 -> v0.16.0
google.golang.org/protobuf v1.33.0 -> v1.34.2

@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch 3 times, most recently from 90bc41c to 54a3b0a Compare June 12, 2024 04:41
@renovate-rancher renovate-rancher bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.19.1 Update module github.com/prometheus/client_golang to v1.19.1 Jun 12, 2024
@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch from 54a3b0a to 3f22b8b Compare June 12, 2024 04:41
@renovate-rancher renovate-rancher bot changed the title Update module github.com/prometheus/client_golang to v1.19.1 chore(deps): update module github.com/prometheus/client_golang to v1.19.1 Jul 6, 2024
@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch 2 times, most recently from 82deefb to fb7b828 Compare July 10, 2024 04:42
@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch from fb7b828 to 5665e09 Compare August 10, 2024 04:56
@renovate-rancher renovate-rancher bot changed the base branch from master to main August 10, 2024 04:56
@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch from 5665e09 to 633435e Compare August 10, 2024 04:56
ericpromislow
ericpromislow previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericpromislow ericpromislow requested a review from a team August 13, 2024 19:40
MbolotSuse
MbolotSuse requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@MbolotSuse MbolotSuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client_golang is a library that we've had issues with before. IIRC there was a breaking change made in between 1.16 and 1.19, and we need to stick to what upstream uses since k8s libraries also use it. Looking at the go.mod for 1.30, it looks like it uses 1.16, so I don't think we should merge this: https://github.com/kubernetes/kubernetes/blob/v1.30.1/go.mod#L56

@renovate-rancher renovate-rancher bot changed the title chore(deps): update module github.com/prometheus/client_golang to v1.19.1 chore(deps): update module github.com/prometheus/client_golang to v1.20.0 Aug 15, 2024
@renovate-rancher renovate-rancher bot force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch from 633435e to 403650e Compare August 15, 2024 05:05
@ericpromislow
Copy link
Contributor

go mod graph shows the following:

github.com/prometheus/common@v0.55.0 github.com/prometheus/client_golang@v1.19.1

Have to dial back to common@v0.44.0

@ericpromislow ericpromislow force-pushed the renovate/git.luolix.top-prometheus-client_golang-1.x branch from a3c3819 to 956e918 Compare August 16, 2024 22:55
@ericpromislow ericpromislow requested review from MbolotSuse and a team August 16, 2024 22:55
@ericpromislow
Copy link
Contributor

Ignore my approval as I made a change, pulling out the prometheus changes.

@renovate-rancher renovate-rancher
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpromislow ericpromislow ericpromislow left review comments

@MbolotSuse MbolotSuse Awaiting requested review from MbolotSuse

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpromislow @MbolotSuse