Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: back port for version 5, add check for external rules while updating roleTemplate #1395

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

matttrach
Copy link
Collaborator

backport #1389 for #1381

Signed-off-by: Pratik Jagrut pratik.jagrut@suse.com
(cherry picked from commit 4d338b6)

…late (rancher#1389)

Signed-off-by: Pratik Jagrut <pratik.jagrut@suse.com>
(cherry picked from commit 4d338b6)
@matttrach matttrach added this to the September Release 2024 milestone Sep 5, 2024
@matttrach matttrach requested a review from jiaqiluo September 5, 2024 16:13
@matttrach matttrach self-assigned this Sep 5, 2024
@matttrach matttrach changed the title fix: back port, add check for external rules while updating roleTemplate fix: back port for version 5, add check for external rules while updating roleTemplate Sep 5, 2024
Copy link
Member

@jiaqiluo jiaqiluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matttrach matttrach merged commit 725a19f into rancher:release/v5 Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants