Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS example fixes #146

Merged
merged 3 commits into from
Jan 22, 2020
Merged

AWS example fixes #146

merged 3 commits into from
Jan 22, 2020

Conversation

donovanmuller
Copy link
Contributor

@donovanmuller donovanmuller commented Jan 21, 2020

When trying the AWS example I encountered a few issues.
Below are the fixes required to successfully bring up a cluster using the example resources:

0b96df5 - Current Docker (releases.rancher.com/install-docker/1.12.sh) install fails with:

module.nodes.aws_instance.rke-node[0] (remote-exec): + sudo -E sh -c 'sleep 3; apt-get install -y -q dirmngr'
module.nodes.aws_instance.rke-node[0] (remote-exec): Reading package lists...

module.nodes.aws_instance.rke-node[0] (remote-exec): Building dependency tree...
module.nodes.aws_instance.rke-node[0] (remote-exec): Reading state information...
module.nodes.aws_instance.rke-node[0] (remote-exec): Some packages could not be installed. This may mean that you have
module.nodes.aws_instance.rke-node[0] (remote-exec): requested an impossible situation or if you are using the unstable
module.nodes.aws_instance.rke-node[0] (remote-exec): distribution that some required packages have not yet been created
module.nodes.aws_instance.rke-node[0] (remote-exec): or been moved out of Incoming.
module.nodes.aws_instance.rke-node[0] (remote-exec): The following information may help to resolve the situation:

module.nodes.aws_instance.rke-node[0] (remote-exec): The following packages have unmet dependencies:
module.nodes.aws_instance.rke-node[0] (remote-exec):  dirmngr : Depends: libassuan0 (>= 2.4.0) but it is not installable
module.nodes.aws_instance.rke-node[0] (remote-exec):            Depends: libnpth0 (>= 0.90) but it is not installable
module.nodes.aws_instance.rke-node[0] (remote-exec): E: Unable to correct problems, you have held broken packages.
module.nodes.aws_instance.rke-node[0] (remote-exec): usermod: group 'docker' does not exist


Error: error executing "/tmp/terraform_2106265970.sh": Process exited with status 6

bumping to https://releases.rancher.com/install-docker/18.09.sh (as per https://rancher.com/docs/rancher/v2.x/en/installation/requirements/installing-docker/).

e003b67 - Due to rancher/rke#1725 we need to include the node internal_address. Additionally, this has to be the IP and not internal DNS, due to etcd-io/etcd#9575

d9d69f4 - Upgrade to rke v1.0.2 to prevent kube-apiserver not starting due to rancher/rke#1805

@donovanmuller donovanmuller changed the title Internal address AWS example fixes Jan 21, 2020
Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @donovanmuller . Thanks for the feedback and the PR.

Could you please take a look to changes requested??

examples/aws_ec2/aws/nodes.tf Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question @donovanmuller, what golang version are you using?? I got some differences executing GO111MODULE=on go mod vendor command.

@donovanmuller
Copy link
Contributor Author

$ go version
go version go1.13.4 darwin/amd64

Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donovanmuller , btm provider is developed using golang 1.12. Modules and vendor updated should be done using same version. That's why i'm encountering diffs on vendor updated done by golang 1.13.

I've submitted a PR just including modules and vendor update to support rke v1.0.2 #148 . Could you please remove your commit that is updating go modules and vendor files and just let the aws examples modifications??

@donovanmuller
Copy link
Contributor Author

@rawmind0 Removed commit efc3294 👍

Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donovanmuller , last detail. PR #148 is already merged, could you please rebase and remove go.mod and go.sum files from your PR??

Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rawmind0 rawmind0 merged commit 308d191 into rancher:master Jan 22, 2020
@donovanmuller donovanmuller deleted the internal_address branch January 22, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants