-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS example fixes #146
AWS example fixes #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @donovanmuller . Thanks for the feedback and the PR.
Could you please take a look to changes requested??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question @donovanmuller, what golang version are you using?? I got some differences executing GO111MODULE=on go mod vendor
command.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donovanmuller , btm provider is developed using golang 1.12. Modules and vendor updated should be done using same version. That's why i'm encountering diffs on vendor updated done by golang 1.13.
I've submitted a PR just including modules and vendor update to support rke v1.0.2 #148 . Could you please remove your commit that is updating go modules and vendor files and just let the aws examples modifications??
63f41ef
to
613aa8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @donovanmuller , last detail. PR #148 is already merged, could you please rebase and remove go.mod
and go.sum
files from your PR??
613aa8a
to
a60ae72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When trying the AWS example I encountered a few issues.
Below are the fixes required to successfully bring up a cluster using the example resources:
0b96df5 - Current Docker (
releases.rancher.com/install-docker/1.12.sh
) install fails with:bumping to
https://releases.rancher.com/install-docker/18.09.sh
(as per https://rancher.com/docs/rancher/v2.x/en/installation/requirements/installing-docker/).e003b67 - Due to rancher/rke#1725 we need to include the node
internal_address
. Additionally, this has to be the IP and not internal DNS, due to etcd-io/etcd#9575d9d69f4 - Upgrade to
rke v1.0.2
to preventkube-apiserver
not starting due to rancher/rke#1805