Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dl.k8s.io for getting kubectl #420

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

superseb
Copy link
Contributor

@superseb superseb commented Oct 25, 2023

Issue: #421

Problem

Preparing for GCS bucket deprecation at some point (kubernetes/k8s.io#2396)

Solution

Change to the currently documented source

Replaces #419

Testing

Engineering Testing

Manual Testing

Automated Testing

  • Test types added/modified:
    • Unit
    • None
  • If "None" - Reason:
  • If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO

QA Testing Considerations

Regressions Considerations

TODO

Existing / newly added automated tests that provide evidence there are no regressions:

  • TODO

Terraform

Click to Expand Terraform

@a-blender
Copy link
Contributor

@superseb Just curious, but is this a required security fix? Lgtm

@a-blender a-blender requested a review from a team October 25, 2023 16:49
@superseb
Copy link
Contributor Author

@a-blender No, just something that came up and will be changed in the future. I created an issue with the upstream reference.

@a-blender a-blender merged commit 56393e4 into rancher:master Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants