Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add config/namespace folder back to properly run kustomize build #176

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Oct 2, 2023

What this PR does / why we need it:
This commit adds back kustomize and namespace yaml files to config/namespace folder in order to successfully run 'kustomize build' from the config/default folder during tilt-up.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

This commit adds back kustomize and namespace yaml files to config/namespace
folder in order to successfully run 'kustomize build' from the config/default
folder during tilt-up.

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 added the kind/bug Something isn't working label Oct 2, 2023
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner October 2, 2023 09:28
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 merged commit 5d7af47 into rancher:main Oct 2, 2023
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the add-ns-files-back branch October 2, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants