Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing nightly images to prime registry #316

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@alexander-demicev alexander-demicev added the kind/bug Something isn't working label Dec 12, 2023
@alexander-demicev alexander-demicev requested a review from a team as a code owner December 12, 2023 11:56
@furkatgofurov7
Copy link
Contributor

Q: why we need to stop?

@alexander-demicev
Copy link
Member Author

@furkatgofurov7 To my understanding prime registry is only for ready and released images, not CI or testing. cc @richardcase

@salasberryfin
Copy link
Contributor

LGTM. Not publishing to the prod registry is also what we agreed on when setting up the nightly release test

salasberryfin
salasberryfin previously approved these changes Dec 12, 2023
richardcase
richardcase previously approved these changes Dec 12, 2023
@furkatgofurov7
Copy link
Contributor

@alexander-demicev can we rebase, otherwise this LGTM

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev alexander-demicev merged commit fecf22a into rancher:main Dec 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants