🌱 Update tests to use same envtest helper, add eventual checks for cache consistency #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
unify-envtest-helper
branch
4 times, most recently
from
08db2b8
to
74e4059
Compare
richardcase
previously approved these changes
Feb 22, 2024
salasberryfin
previously approved these changes
Feb 23, 2024
|
I'd say we should have this merged before #362 so we can re-use the new test helpers without generating conflicts. |
|
@salasberryfin Agree, let me push a round of changes to include komega use across tests, as the combination of Eventually + cl.Get was a pain point for me. Have some changes in another branch I’d like to propagate here + a discovered issue with predicate logic (we can import any cluster on an error in object lookup…) and it should be ready to merge |
Danil-Grigorev
dismissed stale reviews from salasberryfin and richardcase
via
34fe33a
Danil-Grigorev
force-pushed
the
unify-envtest-helper
branch
3 times, most recently
from
973f222
to
ae22d09
Compare
…e consistency Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
4 tasks
salasberryfin
approved these changes
Feb 23, 2024
richardcase
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/chore
What this PR does / why we need it:
This is a refactor of unit tests, which ensures there is no flakes in unit test and moves all tests to a single envtest utility helper across the repo.
This helper already sets up manager instance for the cluster, allowing to write integration tests on our controllers, including testing watch predicates in conjunction.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: