Install RKE2 by default #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
enablerke2
branch
2 times, most recently
from
51db170
to
c1f2b6b
Compare
|
We have to make sure the uninstall process is not broken with this change, which IMO would probably be the case, since we are currently deleting deployment/webhooks specific to Kubeadm only in post-delete hook |
alexander-demicev
force-pushed
the
enablerke2
branch
from
c1f2b6b
to
3977722
Compare
alexander-demicev
force-pushed
the
enablerke2
branch
from
3977722
to
f963f8e
Compare
alexander-demicev
force-pushed
the
enablerke2
branch
from
f963f8e
to
9504e5c
Compare
furkatgofurov7
previously approved these changes
Apr 2, 2024
Danil-Grigorev
previously approved these changes
Apr 3, 2024
alexander-demicev
dismissed stale reviews from Danil-Grigorev and furkatgofurov7
via
d730e2a
alexander-demicev
force-pushed
the
enablerke2
branch
from
9504e5c
to
d730e2a
Compare
alexander-demicev
force-pushed
the
enablerke2
branch
3 times, most recently
from
ea47d2d
to
920e21a
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
enablerke2
branch
from
920e21a
to
bc7de99
Compare
richardcase
approved these changes
Apr 4, 2024
furkatgofurov7
approved these changes
Apr 4, 2024
mbologna
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: