Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git add files in dependabot workflow #556

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented May 27, 2024

What this PR does / why we need it:

Dependabot CI checks are failing on some PRs after replacing the no longer supported action with manual steps example. Looks like this is because the Action we were using sets a default git add . here and it is missing now, so the commit returns error code 1 when there are no changes to commit. This PR simply adds a git add . which hopefully is enough to mimic the removed action's behavior.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@salasberryfin salasberryfin added the kind/bug Something isn't working label May 27, 2024
@salasberryfin salasberryfin requested a review from a team as a code owner May 27, 2024 08:49
@Danil-Grigorev
Copy link
Contributor

We might want to explore using rancher/renovate bot to do these operation in the future. Current workflow is unfortunately very limited and requires manual patches within the changing requirements

@salasberryfin
Copy link
Contributor Author

Thanks @Danil-Grigorev, I agree with your point. I guess we can keep this as a temporary solution and think about migrating this to a more sophisticated alternative.

@Danil-Grigorev
Copy link
Contributor

Yeah, same thinking @salasberryfin. Opened an issue for the future: #558

@alexander-demicev alexander-demicev merged commit c5fd75a into rancher:main May 28, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

3 participants