Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 ADR: v1-v3 automatic migration #579

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

What this PR does / why we need it:

ADR on automatic migration procedure for provisioning.cattle.io/v1 clusters to management.cattle.io/v3 clusters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner June 25, 2024 09:53
@Danil-Grigorev Danil-Grigorev added the kind/documentation Improvements or additions to documentation label Jun 25, 2024
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Danil-Grigorev, LGTM. I will update the proposal in #573 to explicitly state that it refers only to the manual migration method and add a link to this as the primary. Perhaps we could add a reference here to the manual procedure as well?

@Danil-Grigorev
Copy link
Contributor Author

@salasberryfin Makes sense, I’ll add a reference and push some changes soon.

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@Danil-Grigorev Danil-Grigorev merged commit d7ecf2b into rancher:main Jun 26, 2024
9 checks passed
@Danil-Grigorev Danil-Grigorev mentioned this pull request Jul 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

None yet

3 participants