Check agent deployment based on Ready condition
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @Danil-Grigorev. Just added a nit to align log message with new condition. Otherwise, LGTM.
|
Seems like neither |
Danil-Grigorev
force-pushed
the
agent-deployed-based-on-ready
branch
from
f647a49
to
c91f099
Compare
Danil-Grigorev
changed the title
status.ready and ready conditionReady condition
Danil-Grigorev
force-pushed
the
agent-deployed-based-on-ready
branch
from
c91f099
to
bfc73f5
Compare
Danil-Grigorev
force-pushed
the
agent-deployed-based-on-ready
branch
2 times, most recently
from
4d00729
to
323b721
Compare
- Prevent executing cluster import until the child cluster manifests are fully removed. - e2e: Rely on crust-gather for logs collection - Check for cleanup job before import Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
agent-deployed-based-on-ready
branch
from
3a8f2a2
to
dffc6f2
Compare
alexander-demicev
approved these changes
Jul 9, 2024
salasberryfin
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
status.agentDeployedand a corresponding condition in the management v3 cluster is not reflecting if the agent manifests are actually there at all times. If the old manifests are getting removed by cluster re-import or migration, new manifests can be purged by this as well.Readycondition should be better reflecting if turtles need to stop applying manifests.Rancher is performing cleanup job with: https://github.com/rancher/rancher/blob/1c2b815c8dd66e141b21630904127adc8e03c3de/pkg/controllers/management/usercontrollers/controller.go#L289
We need to check for the job existence before performing import operation, and wait for the job and previous manifests to be gone if those are present.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #587
Special notes for your reviewer:
Checklist: