Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: restructure e2e v1v3 suites #594

Merged

Conversation

salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Jul 10, 2024

What this PR does / why we need it:

Structure E2E in differentiated suites for v3 checks, including adding validations for embedded-capi-disabled which so far only has v1 test coverage.

Additionally, this disables tests involving CAPRKE2 + CAPD until we bump CAPI version.

Which issue(s) this PR fixes:
Fixes #477

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@salasberryfin salasberryfin force-pushed the test-e2e-restructure-v1v3-suites branch 2 times, most recently from 7626b45 to 5a7ff7b Compare July 10, 2024 10:57
@salasberryfin salasberryfin changed the title Test e2e restructure v1v3 suites restructure e2e v1v3 suites Jul 10, 2024
@salasberryfin salasberryfin force-pushed the test-e2e-restructure-v1v3-suites branch from 5a7ff7b to 53a2f9c Compare July 10, 2024 11:02
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@salasberryfin salasberryfin force-pushed the test-e2e-restructure-v1v3-suites branch from 53a2f9c to 7743511 Compare July 10, 2024 11:06
@salasberryfin salasberryfin marked this pull request as ready for review July 10, 2024 11:06
@salasberryfin salasberryfin requested a review from a team as a code owner July 10, 2024 11:06
@salasberryfin salasberryfin changed the title restructure e2e v1v3 suites test: restructure e2e v1v3 suites Jul 10, 2024
Danil-Grigorev
Danil-Grigorev previously approved these changes Jul 10, 2024
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@alexander-demicev
Copy link
Member

After some investigation, we found the CAPD is not the source of the error but it still makes sense to keep it with the same CAPI version, maybe we can also include the CAPD version downgrade in this PR.

Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@salasberryfin
Copy link
Contributor Author

Thanks @alexander-demicev @Danil-Grigorev, I included the downgrade in the pr.

@furkatgofurov7
Copy link
Contributor

Additionally, this disables tests involving CAPRKE2 + CAPD until we bump CAPI version.

Is this really necessary to do? I had an impression we will go down that path if the problem was with CAPD, but might be misunderstood .

@alexander-demicev
Copy link
Member

@furkatgofurov7 It's probably not mandatory but we can potentially avoid any issues related to version differences. We will bump CAPI to the latest soon and bring back these tests. We would also need to do some other CAPRKE2 tests that use providers like AWS to test something real that users might deploy.

@salasberryfin salasberryfin merged commit 098ceb8 into rancher:main Jul 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend v3.Cluster coverage in E2E
4 participants