🐛 Apply finalizer on rancher cluster to avoid re-create race condition #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
cluster-recreate-after-delete-race
branch
from
7784884
to
a815fa5
Compare
alexander-demicev
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Thanks @Danil-Grigorev. Just nit-picking a bit on a log message but LGTM.
salasberryfin
approved these changes
Jul 11, 2024
salasberryfin
pushed a commit
to salasberryfin/rancher-turtles
that referenced
this pull request
Jul 18, 2024
…ancher#597) Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
salasberryfin
pushed a commit
to salasberryfin/rancher-turtles
that referenced
this pull request
Jul 18, 2024
…ancher#597) Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As we are unable to set ownership references from CAPI cluster to a cluster scoped management v3 cluster, we have to manage deletion manually. This comes with a problem of tracking deletion order for rancher/capi cluster, and setting
importedannotation to prevent re-import scenario.There is a race condition if removal of management v3 cluster happens too fast - turtles misses the opportunity to set
importedannotation first and causes immediate re-import of the cluster. To prevent such scenario, we need to setcapicluster.turtles.cattle.ioto the management v3 resource we created at all times, and clean it up within theimportedannotation handling scope on deletion.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #589
Special notes for your reviewer:
Checklist: