Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor E2E suite to make it more generic #637

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:
This PR is a part of the E2E refactoring issue, it includes the following changes:

  • Our suite setup includes a lot of duplicate code for setting up management clusters on different infrastructures, I moved all related code to the testenv package. Any potential users of this code can reuse it or take it as an example and implement their own in case their e2e suite setup differs from ours.
  • Some E2E configuration options are passed partially through ginkgo flags and the YAML config. I started moving some options from flags to config files so we have a single place for most configurations. I will open a follow-up PR with moving other values too.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR, 2 comments inline:

test/testenv/turtles.go Outdated Show resolved Hide resolved
test/testenv/turtles.go Outdated Show resolved Hide resolved
salasberryfin
salasberryfin previously approved these changes Aug 6, 2024
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great.

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
}
}

// PreRancherTurtlesInstallHook is a hook that can be used to perform actions before Rancher Turtles is installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// PreRancherTurtlesInstallHook is a hook that can be used to perform actions before Rancher Turtles is installed.
// PreRancherTurtlesUpgradelHook is a hook that can be used to perform actions before Rancher Turtles is upgraded.

test/testenv/turtles.go Show resolved Hide resolved
test/testenv/turtles.go Show resolved Hide resolved
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving the approval as it "needs to be dirty and quick" but leaving some suggestions.

test/testenv/gitea.go Show resolved Hide resolved
test/testenv/rancher.go Show resolved Hide resolved
.github/workflows/e2e-short-test.yaml Show resolved Hide resolved
@alexander-demicev
Copy link
Member Author

@Danil-Grigorev @furkatgofurov7 I will address typos/naming comments in a follow-up PR

@alexander-demicev alexander-demicev merged commit 2abd5a6 into rancher:main Aug 9, 2024
9 checks passed
@alexander-demicev alexander-demicev deleted the e2erefactoring1 branch August 9, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants