Update Windows Container Samples Repository URL #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rak-phillip
changed the title
rak-phillip
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
LGTM - Thanks for identifying this and raising the PR!
This change should be good to merge, as the sample repository replacement already exists1
The intent is to remove the dotnet/core/samples repo such that no images would exist there anymore. This has already been replaced with the existence of the dotnet/samples repo. All tags between the two repos are the same.
Footnotes
Update to the current repo. Old repro will be deleted. dotnet/dotnet-docker#4755
|
Rebased this PR to get latest updates and to trigger CI checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the current samples repo. The old samples repro will be deleted.
See: dotnet/dotnet-docker#4755
FYI on other breaking changes: dotnet/dotnet-docker#4764