Corral-packages maintenance for registries + rancher (rke1/rke2/k3s) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Diamond
force-pushed
the
jkeslar/qa-task-1326
branch
from
ce0aa98 to
77db3db
Compare
This was referenced Jul 31, 2024
markusewalker
approved these changes
Aug 9, 2024
igomez06
reviewed
Aug 21, 2024
| @@ -7,6 +7,7 @@ config="write-kubeconfig-mode: 644 | |||
| cluster-init: true | |||
| tls-san: | |||
| - ${CORRAL_api_host} | |||
| - ${CORRAL_kube_api_host} | |||
There was a problem hiding this comment.
Just making sure, why is this being added as well?
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly test out these changes e2e, I've combined the work from #53 + #54, into a single branch, as both changes are needed to test e2e