Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PBKDF2 with zero iterations #2090

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Fix PBKDF2 with zero iterations #2090

merged 1 commit into from
Aug 31, 2019

Conversation

randombit
Copy link
Owner

It would go into a very long loop.

OpenSSL treats iterations==0 same as iterations==1 but this seems confusing. Instead just reject it.

Unrelated, fix a divide by zero if asked to tune with 0 byte output.

Closes GH #2088

It would go into a very long loop.

OpenSSL treats iterations==0 same as iterations==1 but this seems
confusing. Instead just reject it.

Unrelated, fix a divide by zero if asked to tune with 0 byte output.

Closes GH #2088
@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #2090 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         545      545              
  Lines       59257    59261       +4     
  Branches     6241     6243       +2     
==========================================
+ Hits        54742    54743       +1     
- Misses       4515     4518       +3
Impacted Files Coverage Δ
src/lib/pbkdf/pbkdf2/pbkdf2.cpp 84.09% <50%> (-1.63%) ⬇️
src/lib/pk_pad/emsa_raw/emsa_raw.cpp 71.42% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baac1a8...4530544. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants