Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AABOX2D collision #129

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fixed AABOX2D collision #129

merged 1 commit into from
Mar 13, 2024

Conversation

steven11sjf
Copy link
Contributor

  • Discovered that the AABOX2D format is not (unk, min, max) but is (center, unk, size)
  • center is the "center" of the rect as an offset from the actor vPos
  • size is the (w, h) of the box
  • unk seems to be 0 in the examples i'm working with
  • to render the box ( (cx, cy), u, (w, h) ), the coordinates are:
    • left: vPos.x + cx - w/2
    • right: vPos.x + cx + w/2
    • top: vPos.y + cy - h/2
    • bottom: vPos.y + cy + h/2

screenshots for evidence:

first artaria blob:
image
image

cloak doors in corpius access (large box is the sensor collider):
image
image

screw attack room spinner (boxes on the sides are the colliders to turn it, I assume only the right is activated):
image

hidden door in cataris below first EMMI entrance:
image

Burenia hub to dairon, underwater blob section:
image

- Discovered that the AABOX2D format is not (unk, min, max) but is
  (center, unk, size)
- center is the "center" of the rect as an offset from the actor vPos
- size is the (w, h) of the box
- unk seems to be 0 in the examples i'm working with
- to render the box ( (cx, cy), u, (w, h) ), the coordinates are:
  - left: vPos.x + cx - w/2
  - right: vPos.x + cx + w/2
  - top: vPos.y + cy - h/2
  - bottom: vPos.y + cy + h/2
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.13%. Comparing base (d7bc560) to head (f1129fb).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files          63       63           
  Lines        3155     3155           
=======================================
  Hits         2339     2339           
  Misses        816      816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyceron
Copy link
Contributor

dyceron commented Mar 13, 2024

I wonder if this is the same for SR

@duncathan duncathan added this pull request to the merge queue Mar 13, 2024
Merged via the queue into randovania:main with commit cd5bea6 Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants