Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade commander from 5.0.0 to 5.1.0 #47

Merged
merged 2 commits into from
Apr 30, 2020

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to upgrade commander from 5.0.0 to 5.1.0.

merge advice

✨What is Merge Advice? We check thousands of dependency upgrade pull requests and CI tests every day to see which upgrades were successfully merged. After crunching this data, we give a recommendation on how safe we think the change is for you to merge without causing issues. Learn more, and share your feedback to help improve this feature. 🙏
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
  • The recommended version is 1 version ahead of your current version.
  • The recommended version was released 5 days ago, on 2020-04-25.
Release notes
Package name: commander
  • 5.1.0 - 2020-04-25

    Added

    • support for multiple command aliases, the first of which is shown in the auto-generated help (#531, #1236)
    • configuration support in addCommand() for hidden and isDefault (#1232)

    Fixed

    • omit masked help flags from the displayed help (#645, #1247)
    • remove old short help flag when change help flags using helpOption (#1248)

    Changed

    • remove use of arguments to improve auto-generated help in editors (#1235)
    • rename .command() configuration noHelp to hidden (but not remove old support) (#1232)
    • improvements to documentation
    • update dependencies
    • update tested versions of node
    • eliminate lint errors in TypeScript (#1208)
  • 5.0.0 - 2020-03-14

    Added

    • support for nested commands with action-handlers (#1 #764 #1149)
    • .addCommand() for adding a separately configured command (#764 #1149)
    • allow a non-executable to be set as the default command (#742 #1149)
    • implicit help command when there are subcommands (previously only if executables) (#1149)
    • customise implicit help command with .addHelpCommand() (#1149)
    • display error message for unknown subcommand, by default (#432 #1088 #1149)
    • display help for missing subcommand, by default (#1088 #1149)
    • combined short options as single argument may include boolean flags and value flag and value (e.g. -a -b -p 80 can be written as -abp80) (#1145)
    • .parseOption() includes short flag and long flag expansions (#1145)
    • .helpInformation() returns help text as a string, previously a private routine (#1169)
    • .parse() implicitly uses process.argv if arguments not specified (#1172)
    • optionally specify where .parse() arguments "from", if not following node conventions (#512 #1172)
    • suggest help option along with unknown command error (#1179)
    • TypeScript definition for commands property of Command (#1184)
    • export program property (#1195)
    • createCommand factory method to simplify subclassing (#1191)

    Fixed

    • preserve argument order in subcommands (#508 #962 #1138)
    • do not emit command:* for executable subcommands (#809 #1149)
    • action handler called whether or not there are non-option arguments (#1062 #1149)
    • combining option short flag and value in single argument now works for subcommands (#1145)
    • only add implicit help command when it will not conflict with other uses of argument (#1153 #1149)
    • implicit help command works with command aliases (#948 #1149)
    • options are validated whether or not there is an action handler (#1149)

    Changed

    • Breaking .args contains command arguments with just recognised options removed (#1032 #1138)
    • Breaking display error if required argument for command is missing (#995 #1149)
    • tighten TypeScript definition of custom option processing function passed to .option() (#1119)
    • Breaking .allowUnknownOption() (#802 #1138)
      • unknown options included in arguments passed to command action handler
      • unknown options included in .args
    • only recognised option short flags and long flags are expanded (e.g. -ab or --foo=bar) (#1145)
    • Breaking .parseOptions() (#1138)
      • args in returned result renamed operands and does not include anything after first unknown option
      • unknown in returned result has arguments after first unknown option including operands, not just options and values
    • Breaking .on('command:*', callback) and other command events passed (changed) results from .parseOptions, i.e. operands and unknown (#1138)
    • refactor Option from prototype to class (#1133)
    • refactor Command from prototype to class (#1159)
    • changes to error handling (#1165)
      • throw for author error, not just display message
      • preflight for variadic error
      • add tips to missing subcommand executable
    • TypeScript fluent return types changed to be more subclass friendly, return this rather than Command (#1180)
    • .parseAsync returns Promise<this> to be consistent with .parse() (#1180)
    • update dependencies

    Removed

    • removed EventEmitter from TypeScript definition for Command, eliminating implicit peer dependency on @types/node (#1146)
    • removed private function normalize (the functionality has been integrated into parseOptions) (#1145)
    • parseExpectedArgs is now private (#1149)

    Migration Tips

    If you use .on('command:*') or more complicated tests to detect an unrecognised subcommand, you may be able to delete the code and rely on the default behaviour.

    If you use program.args or more complicated tests to detect a missing subcommand, you may be able to delete the code and rely on the default behaviour.

    If you use .command('*') to add a default command, you may be be able to switch to isDefault:true with a named command.

from commander GitHub release notes
Commit messages
Package name: commander
  • 6405325 Prepare for release (#1255)
  • 8c9cfbb Add Node.js 14 to the CI settings of GitHub Actions (#1253)
  • b8baafb Update dependencies (#1251)
  • e1966fc Omit the help flags from help that are masked by other options (#1247)
  • 56221f7 Allow helpOption to only include long flag (#1248)
  • 28e8d3f Add support for multiple aliases (#1236)
  • b59adfc Replace use of arguments.length (#1235)
  • b5d95ee Add opts to addCommand, and rename noHelp to hidden (#1232)
  • 8ec3e7f Consistently refer to returning this for chaining (not parent) (#1231)
  • 2c0a237 Remove most uses of top-level, as less accurate now with command nesting. (#1230)
  • e960c90 Fixing lint errors in TypeScript (#1208)
  • ebc8b41 Merge pull request #1221 from shadowspawn/feature/nested-typos
  • 2ffa6f2 Add 5.x, EOL for 4.x (#1222)
  • c3895db Add 5.x, EOL for 4.x
  • 9b0a991 Fix typos

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix: upgrade commander from 5.0.0 to 5.1.0

     fix: upgrade commander from 5.0.0 to 5.1.0

Powered by Pull Assistant. Last update ae017c7 ... d73908a. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Apr 30, 2020

Code Climate has analyzed commit d73908a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.1%.

View more on Code Climate.

@randytarampi randytarampi merged commit e4411a8 into master Apr 30, 2020
@randytarampi randytarampi deleted the snyk-upgrade-c71eeac2d4b305ea52631c46f4f2ec4d branch April 30, 2020 19:49
@randytarampi
Copy link
Owner

🎉 This PR is included in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants