Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(greenkeeper): Update dependencies and enable Greenkeeper #39

Merged
merged 4 commits into from
May 4, 2019

Conversation

greenkeeper[bot]
Copy link

@greenkeeper greenkeeper bot commented May 4, 2019

Let’s get started with automated dependency management for slamscan 💪

🔒 Greenkeeper has found a package-lock.json file in this repository. Greenkeeper supports lockfile updates for public packages. If you use private packages in your repository, please use greenkeeper-lockfile to make sure these can get updated as well.

This pull request updates all your dependencies to their latest version. Having them all up to date really is the best starting point for keeping up with new releases. Greenkeeper will look out for further dependency updates and make sure to handle them in isolation and in real-time, but only after you merge this pull request.

Important: Greenkeeper will only start watching this repository’s dependency updates after you merge this initial pull request.


💥 Tests on this branch are failing. Here’s how to proceed.

To solve the issue, first find out which of the dependency’s updates is causing the problem. Then fix your code to accomodate the changes in the updated dependency. next-update is a really handy tool to help you with this.

Then push your changes to this branch and merge it.

🏗 How to configure Travis CI

Greenkeeper has added a rule to your .travis.yml that whitelists Greenkeeper branches, which are created when your dependencies are updated. Travis CI will run your tests on these branches automatically to see if they still pass.

No additional setup is required 😊

🙈 How to ignore certain dependencies

You may have good reasons for not wanting to update to a certain dependency right now. In this case, you can change the dependency’s version string in the package.json file back to whatever you prefer.

To make sure Greenkeeper doesn’t nag you again on the next update, add a greenkeeper.ignore field to your package.json, containing a list of dependencies you don’t want to update.

// package.json
{
  
  "greenkeeper": {
    "ignore": [
      "package-names",
      "you-want-me-to-ignore"
    ]
  }
}
👩‍💻 How to update this pull request
  # Change into your repository’s directory
  git fetch --all
  git checkout greenkeeper/initial
  npm install-test
  # Adapt your code until everything works again
  git commit -m 'chore: adapt code to updated dependencies'
  git push https://github.com/randytarampi/slamscan.git greenkeeper/initial
✨ How do dependency updates work with Greenkeeper?

After you merge this pull request, Greenkeeper will create a new branch whenever a dependency is updated, with the new version applied. The branch creation should trigger your testing services and check whether your code still works with the new dependency version. Depending on the the results of these tests Greenkeeper will try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

The above example shows an in-range update. 1.7.0 is included in the old ^1.6.0 range, because of the caret ^ character .
When the test services report success Greenkeeper will silently delete the branch again, because no action needs to be taken – everything is fine.

However, should the tests fail, Greenkeeper will create an issue to inform you about the problem immediately.

This way, you’ll never be surprised by a dependency breaking your code. As long as everything still works, Greenkeeper will stay out of your way, and as soon as something goes wrong, you’ll be the first to know.

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

In this example, the new version 4.0.0 is not included in the old ^3.0.0 range.
For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.

This means that you no longer need to check for new versions manually – Greenkeeper will keep you up to date automatically.

These pull requests not only serve as reminders to update: If you have solid tests and good coverage, and the pull requests passes those tests, you can very likely just merge it and release a new version of your software straight away :shipit:

To get a better idea of which ranges apply to which releases, check out the extremely useful semver calculator provided by npm.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Good luck with your project and see you soon ✨

Your Greenkeeper bot 🌴

@coveralls
Copy link

Pull Request Test Coverage Report for Build 175

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 62 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-68.07%) to 24.37%

Files with Coverage Reduction New Missed Lines %
src/lib/util/getTagsForFileInBucket.js 1 50.0%
src/lib/util/downloadFileFromBucket.js 1 50.0%
src/serverless/util/configureEnvironment.js 1 40.0%
src/lib/util/putTagsOnS3Object.js 1 50.0%
src/lib/clamscan.js 1 75.0%
src/lib/util/createTempDirectory.js 3 16.67%
src/lib/util/readFile.js 3 16.67%
src/lib/util/cleanupTempFiles.js 3 16.67%
src/serverless/handlers/updateDefinitions.js 4 20.0%
src/lib/downloadClamscanDbFilesFromS3.js 5 22.22%
Totals Coverage Status
Change from base Build 173: -68.07%
Covered Lines: 28
Relevant Lines: 95

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 4, 2019

Pull Request Test Coverage Report for Build 175

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 62 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-68.07%) to 24.37%

Files with Coverage Reduction New Missed Lines %
src/lib/util/getTagsForFileInBucket.js 1 50.0%
src/lib/util/downloadFileFromBucket.js 1 50.0%
src/serverless/util/configureEnvironment.js 1 40.0%
src/lib/util/putTagsOnS3Object.js 1 50.0%
src/lib/clamscan.js 1 75.0%
src/lib/util/createTempDirectory.js 3 16.67%
src/lib/util/readFile.js 3 16.67%
src/lib/util/cleanupTempFiles.js 3 16.67%
src/serverless/handlers/updateDefinitions.js 4 20.0%
src/lib/downloadClamscanDbFilesFromS3.js 5 22.22%
Totals Coverage Status
Change from base Build 173: -68.07%
Covered Lines: 28
Relevant Lines: 95

💛 - Coveralls

@ghost ghost assigned randytarampi May 4, 2019
@ghost ghost added the in progress label May 4, 2019
@randytarampi randytarampi merged commit e2ea624 into master May 4, 2019
@randytarampi randytarampi deleted the greenkeeper/initial branch May 4, 2019 20:51
@ghost ghost removed the in progress label May 4, 2019
@randytarampi
Copy link
Owner

🎉 This PR is included in version 2.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants