Added TypIcons font #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sepbehroozi
commented
Sep 5, 2018
sepbehroozi
commented
- Added TypIcons font and items to SwiftIcons.swift
- Added TypIcons.ttf font file
- Updated sample project for TypIcons
- Removed unused 'break' of 'switch statements' in whole project
- Updated readme.md
- Added TypIcons.ttf font file - Updated sample project for TypIcons - Removed unused 'break' of 'switch statements' in whole project
ranesr
reviewed
Sep 10, 2018
README.md
Outdated
| @@ -123,6 +124,8 @@ Copy all the files from `Source` folder. | |||
| - OpenIconic.ttf | |||
| - Stateface.ttf | |||
| - WeatherIcons.ttf | |||
| - WeatherIcons.ttf | |||
There was a problem hiding this comment.
Can you remove this line? WeatherIcons is listed twice here. Thanks.
There was a problem hiding this comment.
Oops! yes sure.
Thanks for noticing!
- Added TypIcons.ttf font file - Updated sample project for TypIcons - Removed unused 'break' of 'switch statements' in whole project
ranesr
approved these changes
Sep 15, 2018
|
Thank you @3pehrbehroozi for your contribution. Merging these changes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.