realpath performance improvements + error handling #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does 2 things:
fs.realpathSync.native
in non-Windows environments and usefs.realpathSync
on Windowsfs.realpathSync
is 70x slower thanfs.realpathSync.native
: fs.realpath 70x slower than native nodejs/node#2680fs.realpathSync.native
has undefined behavior with the Windows network drive, which could cause unexpected behavior.NodeModule.realpath
getterNodeModule.realpath
fall back toNodeModule.path
when encountering anENOENT
error.package.json
'soverwrites
field with@favware/skip-dependency
, the module will have a symlink point to a non-existing path, causingfs.realpathSync
to choke.