Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a requests session per FinTSHTTPSConnection #161

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Use a requests session per FinTSHTTPSConnection #161

merged 1 commit into from
Mar 28, 2024

Conversation

michaelgruenewald
Copy link
Contributor

This creates a requests session per FinTSHTTPSConnection. This mostly results in requests reusing the HTTPS connection, leading to fewer roundtrips and lower latency overall. It would also allow cookie sharing, etc., but I don't think that matters at all for any FinTS stuff. Given that it's also an isolated session per FinTSHTTPSConnection, I don't see how this could have a negative impact.

Tested with my bank.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (eb94706) to head (0b6a64b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   87.84%   87.85%           
=======================================
  Files          26       26           
  Lines        3341     3342    +1     
=======================================
+ Hits         2935     2936    +1     
  Misses        406      406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphaelm raphaelm merged commit 3df572f into raphaelm:master Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants