Broken FinInstnId

[FrankKipf]

Adding a payment without BIC leads to a broken <FinInstnId>

It should look like this:

<DrctDbtTxInf> ... <DbtrAgt> <FinInstnId> <Othr> <Id>NOTPROVIDED</Id> </Othr> </FinInstnId> </DbtrAgt> ... </DrctDbtTxInf>

But instead I receive that output:

<DrctDbtTxInf> ... <DbtrAgt> <FinInstnId/> </DbtrAgt> ... </DrctDbtTxInf>

I'm not sure, but I think in debit.py line 268 and line 269 have to be swapped with each other.

[Varchibald]

I have the same issue using pain.008.001.02.

I actually fixed it by removing the condition on line 345 in debit.py: elif self.schema != 'pain.008.001.02' and self.schema != 'pain.008.002.02'

Not sure why that was there in the first place..

[FrankKipf]

I added a BIC to each payment. If you don't have the BIC, take a look at openiban.com

[Varchibald]

I need BICs from a broader range of countries than what is supported by openiban, unfortunately. I edited my solution in previous answer, maybe I'll open a PR later.

[Varchibald]

@raphaelm do you know why this condition was put in there?

[raphaelm]

No, not reall

[Varchibald]

I assume the original merge @ #25 wanted the BIC-notprovided interaction only for their format (pain.008.003.02), so they excluded the other formats for fault of testing. Imo it shouldn't cause any issues if the exception is removed.

[dominiks96]

This condition is simply wrong still. Also for pain.008.001.02, according to the German Bundesbank, see docs https://www.bundesbank.de/resource/blob/877540/eec34592d2bf123596897cf29448e04b/mL/technische-spezifikationen-sepa-lastschriften-2023-11-data.pdf

Bei nationalen und grenzüberschreitenden SEPA-Lastschriften (CORE/B2B) ist die
Angabe des BIC des Zahlungsdienstleisters des Zahlers grundsätzlich entbehrlich; sofern auf die Angabe des BIC verzichtet wird, ist das Element
mit der Konstante NOTPROVIDED zu belegen.

(Translated by DeepL)

For national and cross-border SEPA direct debits (CORE/B2B), it is generally not necessary to specify the BIC of the payer's payment service provider; if the BIC is not specified, the element must be assigned the constant NOTPROVIDED.

IMO, the elif here and here should simply be replaced by an else.

@raphaelm mind having a look? Debits are failing due to this. Commerzbank rejects them due to xml pain validation.

[raphaelm]

I currently do not have the time to look at this until it is a case that affects us, but I'm happy to accept PRs that fix it.

[dominiks96]

@raphaelm I'll give it a shot and create a PR.

Would be cool, if you could assemble a release including the fix soon. Otherwise, using it is kind of a lot of effort for most of the users probably.

[dominiks96]

@raphaelm PR is here. I tested it in the commerzbank online portal and also using the windata app