Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented pain.008.003.02 transactions without BIC #25

Merged
merged 2 commits into from
Dec 23, 2019

Conversation

alphanoob1337
Copy link
Contributor

Added support for payment information and configuration without BIC for pain.008.003.02 scheme.

@raphaelm
Copy link
Owner

Thanks a lot! Can you resolve the two style issues?

sepaxml/debit.py:456:1: W293 blank line contains whitespace

tests/test_no_bic_00800302.py:15:9: E265 block comment should start with '# '

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #25 into master will decrease coverage by 0.57%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage    97.3%   96.73%   -0.58%     
==========================================
  Files          22       23       +1     
  Lines         854      888      +34     
==========================================
+ Hits          831      859      +28     
- Misses         23       29       +6
Impacted Files Coverage Δ
tests/test_no_bic_00800302.py 100% <100%> (ø)
sepaxml/debit.py 95.89% <70%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98934ba...425afaf. Read the comment docs.

@raphaelm raphaelm merged commit 5751fd4 into raphaelm:master Dec 23, 2019
@Varchibald Varchibald mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants