-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding to description for non parametrics array #333
base: main
Are you sure you want to change the base?
Conversation
I dont understand what is the relation is pairwise_tests.py and test_power.py::TestPower::test_power_chi2 |
Don't worry about the unit tests, I can take care of that later. I will leave a few comments on the PR now |
pingouin/pairwise.py
Outdated
@@ -121,7 +121,8 @@ def pairwise_tests( | |||
|
|||
.. versionadded:: 0.2.9 | |||
return_desc : boolean | |||
If True, append group means and std to the output dataframe | |||
If True, append group means and std for parametrics=True (default) to the output dataframe, if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace with "If True, append group means and std to the output dataframe when parametric=True
(defaut), or median and IQR when parametric=False
."
Sure, I will assist you in making the code more efficient and elegant based on my suggestions. Thank you. |
Here is the suggestions, thank you
Tooooooooooooooooo slow @raphaelvallat |
Hi @turkalpmd — the code looks good but I will need to update the unit tests and resolve conflicts in |
Hi @raphaelvallat, I completely understand and appreciate the fact that Pingouin is a non-profit library and that your contributions are made voluntarily in your free time. I never intended to pressure you, and I’m fully aware of the demands of having a full-time job and family commitments. However, if you see us as part of the community's strength, I believe we could collectively make things move faster. We’re all busy, but I genuinely love this library and am grateful for everything you’ve done. Additionally, I’ve developed the function you previously mentioned and created a repository for it. I’d be happy to turn it into a PR for Pingouin whenever you think it’s a good time. Here is this isue topic about the Ransacking method Thank you again, and best of luck with your work. |
Hi @turkalpmd, Thanks for your message. May I suggest that you take a stab at creating the unit tests for this function? This will definitely save me some precious time. No need to add anything fancy, we just need to validate that the column names and values have been updated with "parametric=False". As for the function, can you please copy-paste the link to your repository in #404? Thanks again, |
I will have this completed by next week. |
I got problems and solved it but this time I received Lint error, I will fixing.