Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\tllabelcventry Support to specify label for end date #15

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

ypid
Copy link
Contributor

@ypid ypid commented Jan 26, 2017

Most of the work was already prepared in #9 but was not enabled for some reason. I only needed to fix two minor details to make it work for the \tllabelcventry macro. Thanks to @Astrinus.

@@ -62,6 +62,7 @@
% Right brace \} Tilde \~}
%
%
% ^^A \changes{0.10}{2015/08/31}{Add support to specify label for end date, thanks to ypid and Astrinus}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the ^^A ? typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No typo, it is a comment in the comment as this version has not been released yet. I wanted to prepare the changelog for you 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I can also remove it, should not matter much.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm fine to remove it then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, I updated the commit.

@@ -62,6 +62,7 @@
% Right brace \} Tilde \~}
%
%
% \changes{0.10}{2015/08/31}{Add support to specify label for end date, thanks to ypid and Astrinus}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date is wrong though. I don't mind releasing it today if I merge that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Most of the work was already prepared in
raphink#9 but was not enabled for
some reason. I only needed to fix two minor details to make it work for
the \tllabelcventry macro. Thanks to @Astrinus.
@raphink raphink merged commit 327267b into raphink:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants