Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hardware acceleration #123

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Disable hardware acceleration #123

merged 1 commit into from
Nov 12, 2018

Conversation

davepgreene
Copy link
Contributor

There's absolutely no reason that hardware acceleration should be enabled by default and on a Mac laptop it will pin the GPU to discrete graphics mode which eats up battery life.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.625% when pulling 72a447d on davepgreene:disable-hardware-acceleration into 98c49fd on rapid7:master.

fmitchell-r7
fmitchell-r7 approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@fmitchell-r7 fmitchell-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@dgreene-r7 dgreene-r7 merged commit 1b3f87a into rapid7:master Nov 12, 2018
@dgreene-r7 dgreene-r7 deleted the disable-hardware-acceleration branch November 12, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmitchell-r7 fmitchell-r7 fmitchell-r7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davepgreene @coveralls @fmitchell-r7 @dgreene-r7