Patching fedramp usage #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using with FedRamp accounts, swapping between commercial and fedramp had issues because the region was incorrect when switching back to commercial
cdoughty-r7
requested review from
dgreene-r7,
mfreebairn-r7,
sspaeth-r7 and
roconnor-r7
dgreene-r7
reviewed
Mar 15, 2022
Co-authored-by: Dave Greene <dgreene@rapid7.com>
cdoughty-r7
requested review from
ceastman-r7,
dgreene-r7,
fmitchell-r7,
batchison-r7 and
jpena-r7
erran-r7
approved these changes
Mar 16, 2022
mfreebairn-r7
approved these changes
Mar 16, 2022
batchison-r7
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using with FedRamp and commercial accounts, swapping between types had issues because the region was incorrect.
Testing
Ran testing here with combined branches:
https://github.com/rapid7/awsaml/actions/runs/1993263022