Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in lib/msf/core/payload/php.rb #19491

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jvoisin
Copy link
Contributor

@jvoisin jvoisin commented Sep 22, 2024

As it seems that shuffle is a method
(https://ruby-doc.org/core-2.7.0/Array.html#method-i-shuffle) and not a function.

As spotted by @Chocapikk in
#19445 (review)

@cgranleese-r7 cgranleese-r7 self-assigned this Sep 23, 2024
@cgranleese-r7 cgranleese-r7 added the rn-fix release notes fix label Sep 23, 2024
@cgranleese-r7 cgranleese-r7 merged commit a27d491 into rapid7:master Sep 23, 2024
69 checks passed
@cgranleese-r7
Copy link
Contributor

Release Notes

Fixes a crash in lib/msf/core/payload/php.rb.

@jvoisin jvoisin deleted the fix_php branch September 23, 2024 11:01
@jvoisin
Copy link
Contributor Author

jvoisin commented Sep 23, 2024

Thank you for the quick merge, and sorry about this :<

@cgranleese-r7
Copy link
Contributor

No problem, was my bad for missing it during review. Thanks.

@cdelafuente-r7
Copy link
Contributor

Release Notes

This fixes a crash in lib/msf/core/payload/php.rb when calling the shuffle method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants